Add back galaxy watch 4 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkong-ds
requested changes
Aug 22, 2024
src/scripts/device_info.json
Outdated
| @@ -6752,6 +6752,123 @@ | |||
| ], | |||
| "is_mockup_image_at_front": true, | |||
| "available_perspectives": ["Portrait", "Landscape"] | |||
| }, | |||
| { | |||
| "credits": "<p><a href=\"http://facebook.design/devices\" target=\"blank\">Facebook - Design Resources</a></p>", | |||
There was a problem hiding this comment.
This should be skymaker, can search skymaker in same file for copying
src/scripts/device_info.json
Outdated
| "available_perspectives": ["Portrait", "Landscape"] | ||
| }, | ||
| { | ||
| "credits": "<p><a href=\"http://facebook.design/devices\" target=\"blank\">Facebook - Design Resources</a></p>", |
src/scripts/device_info.json
Outdated
| "available_perspectives": ["Portrait", "Landscape"] | ||
| }, | ||
| { | ||
| "credits": "<p><a href=\"http://facebook.design/devices\" target=\"blank\">Facebook - Design Resources</a></p>", |
YayunHuang
force-pushed
the
133-add-galaxy-watch-4
branch
from
e084feb to
da1452f
Compare
|
@pkong-ds updated, thanks |
pkong-ds
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: MUP-133
Screen.Recording.2024-08-22.at.2.28.07.PM.mov