Fix input filenames with dot . parsed incorrectly
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkong-ds
force-pushed
the
mup-114-mockuping-multiple-images-at-once
branch
from
363c297 to
a778b2a
Compare
pkong-ds
force-pushed
the
mup-114-mockuping-multiple-images-at-once
branch
from
a778b2a to
e3cde34
Compare
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #69
Problem
Previously, filename parsing method is implemented with custom code like
split('.')instead ofos.path.splitext()Solution
Use
os.path.splitextinsteadTest run
Input
Output
apple-iphone-15-black-mockup(2).zip