Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass more node child process tests #16863

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft

Pass more node child process tests #16863

wants to merge 39 commits into from

Conversation

pfgithub
Copy link
Contributor

@pfgithub pfgithub commented Jan 29, 2025

Breaking changes:

  • args[0] and argv0 in Bun.spawn/spawnSync is reversed and now matches node.js
    • previously: spawnSync({cmd: ["true"], argv0: "false"}) // would execute "false"
    • now: spawnSync({cmd: ["true"], argv0: "false"}) // executes "true"

New features:

  • Timeout is now supported in child_process execSync/spawnSync and Bun.spawn/spawnSync

BUN-10684

@robobun
Copy link

robobun commented Jan 29, 2025

Updated 9:08 PM PT - Mar 7th, 2025

@pfgithub, your commit a515976 has 7 failures in Build #12882:


🧪   try this PR locally:

bunx bun-pr 16863

@pfgithub pfgithub force-pushed the pfg/child-process branch 2 times, most recently from 719aa68 to 47647aa Compare February 6, 2025 04:26
@pfgithub pfgithub force-pushed the pfg/child-process branch 7 times, most recently from ffb0021 to 6c6bb05 Compare February 19, 2025 23:27
@pfgithub pfgithub marked this pull request as ready for review February 20, 2025 00:42
@pfgithub pfgithub marked this pull request as draft February 20, 2025 22:39
@pfgithub pfgithub force-pushed the pfg/child-process branch 2 times, most recently from 30ae06b to a8686c9 Compare February 25, 2025 23:19
@pfgithub pfgithub force-pushed the pfg/child-process branch 4 times, most recently from 0c26d48 to e7d6560 Compare March 1, 2025 02:09
@pfgithub pfgithub marked this pull request as ready for review March 1, 2025 03:22
@pfgithub pfgithub force-pushed the pfg/child-process branch 6 times, most recently from 8bac41a to 3f71fa5 Compare March 6, 2025 22:41
@pfgithub pfgithub marked this pull request as draft March 7, 2025 01:01
pfgithub added 7 commits March 7, 2025 15:22
It is an internal test that doesn't apply to bun, and it was being skipped because of a bug with bun's implementation of spawnSync('...').error filling 'error' when spawn returned a non-zero exit code.
@pfgithub pfgithub force-pushed the pfg/child-process branch from 67a5fa3 to 19059eb Compare March 7, 2025 23:22
@pfgithub pfgithub force-pushed the pfg/child-process branch from 19059eb to c81de1f Compare March 7, 2025 23:33
@pfgithub pfgithub force-pushed the pfg/child-process branch 2 times, most recently from c621d3d to b3b4280 Compare March 8, 2025 02:55
@pfgithub pfgithub force-pushed the pfg/child-process branch from b3b4280 to a515976 Compare March 8, 2025 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants