sqlite: Enable passing options to Database.deserialize to enable strict mode #17726
+87
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #17689 |
|
The failures seem to be unrelated to the changes in this PR. However, if there is something I should do to resolve them, let me know :) |
Co-authored-by: Jarred Sumner <[email protected]>
Co-authored-by: Jarred Sumner <[email protected]>
|
(On phone using Github's "commit suggested changes" functionality. Unsure if it works well. Will double check later on desktop.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates
bun:sqliteDatabase.deserializeto take in an object of options similar tonew Database()so strict mode can be enabled on a deserialized database.How did you verify your code works?
I wrote automated tests
bun-debug test test-file-name.test)