Check if path exists before returning from opendirSync #17846
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperclover
requested changes
Mar 3, 2025
| @@ -1021,6 +1021,10 @@ function _toUnixTimestamp(time: any, name = "time") { | |||
| function opendirSync(path, options) { | |||
| // TODO: validatePath | |||
| // validateString(path, "path"); | |||
| if (!fs.existsSync(path)) { | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
accessSync won't error if it's not a directory
There was a problem hiding this comment.
true. then instead, this PR should expose an opendir binding in src/bun.js/node/node_fs_binding.zig to fs.ts, and have a matching implementation function in src/bun.js/node/node_fs.zig. this function would return a directory file descriptor. Then, there can be internal variants of readdir that work on this file descriptor.
| describe("opendirSync", () => { | ||
| it("should throw ENOENT on a nonexistent directory", () => { | ||
| const dirName = Math.random().toString(8); | ||
| expect(() => opendirSync(dirName)).toThrow("ENOENT"); |
There was a problem hiding this comment.
.toThrow({ code: "ENOENT" })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17581
What does this PR do?
How did you verify your code works?
One thing I don't quite see a pattern for yet is returning a system error (e.g.
ENOENT) from JS code, but it seems like the typical way to do that is by putting the implementation into the Zig code.I figured I'd raise the PR while I look at how to do that in case there's a way to do it from JS though