Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node/net): add test-net-socket-constructor #17879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Mar 3, 2025

What does this PR do?

gets parallel/test-net-socket-constructor.js passing

How did you verify your code works?

There is a test

@DonIsaac DonIsaac requested a review from nektro March 3, 2025 21:51
@robobun
Copy link

robobun commented Mar 3, 2025

Updated 3:04 PM PT - Mar 3rd, 2025

@DonIsaac, your commit d637c2a has 3 failures in Build #12599:


🧪   try this PR locally:

bunx bun-pr 17879

@nektro
Copy link
Member

nektro commented Mar 3, 2025

this only validates + stores the fd, not actually add any behavior
also doesnt use the same validator as node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants