Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bundler): comprehensive TOML testing #17886

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

test(bundler): comprehensive TOML testing #17886

wants to merge 19 commits into from

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Mar 4, 2025

What does this PR do?

Runs our transpiler and module loader against all cases from toml-lang/toml-test. Results are saved into a snapshot, since not all tests pass. As we make fixes, we can use the -u flag to update them. This also prevents accidental regressions in TOML parsing.

This is still a draft because some WebKit assertions are failing in import cases. I'll either skip those for now or fix them in this PR.

I plan on fixing bugs found by these tests in the near future.

Related issues:

How did you verify your code works?

Lots and lots of tests

@robobun
Copy link

robobun commented Mar 4, 2025

@DonIsaac DonIsaac marked this pull request as draft March 4, 2025 01:37
@DonIsaac DonIsaac linked an issue Mar 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundler: importing TOML objects with numeric keys fails
2 participants