Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell): remove unecessary allocations when printing errors #17898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Mar 4, 2025

What does this PR do?

Removes some unnecessary allocations that were occurring when formatting and printing shell errors.

How did you verify your code works?

Current tests will cover these changes.

@DonIsaac DonIsaac added performance An issue with performance shell Something to do with Bun as a shell labels Mar 4, 2025
@DonIsaac DonIsaac requested a review from zackradisic March 4, 2025 21:22
@robobun
Copy link

robobun commented Mar 4, 2025

Updated 2:05 PM PT - Mar 4th, 2025

@DonIsaac, your commit 1f7d64c has 3 failures in Build #12659:


🧪   try this PR locally:

bunx bun-pr 17898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance An issue with performance shell Something to do with Bun as a shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants