node:crypto: native Hmac and Hash
#17920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 9:34 PM PT - Mar 6th, 2025
❌ @dylan-conway, your commit fbe992d has 2 failures in
🧪 try this PR locally: bunx bun-pr 17920 |
dylan-conway
changed the title
node:crypto: native Hmacnode:crypto: native Hmac and Hash
dylan-conway
force-pushed
the
dylan/native-hmac
branch
from
8fb4cbe to
9714b50
Compare
paperclover
reviewed
Mar 7, 2025
| @@ -2337,6 +2337,111 @@ pub const Crypto = struct { | |||
| pub usingnamespace JSC.Codegen.JSCryptoHasher; | |||
| usingnamespace bun.New(@This()); | |||
|
|
|||
| // For using only CryptoHasherZig in c++ | |||
| pub const Extern = struct { | |||
There was a problem hiding this comment.
non-blocking note: when zig structs do not contain fields, it is convention to name them snake case lowercase since it is just a namespace.
|
|
||
| case WebCore::BufferEncodingType::ucs2: | ||
| case WebCore::BufferEncodingType::utf16le: { | ||
| memcpy(data.data(), bytes.data(), bytes.size()); |
There was a problem hiding this comment.
thinking
it would be interesting if all our memcpy calls had ASSERT(data.size() >= bytes.size())
| hmac->m_ctx.reset(); | ||
| } | ||
|
|
||
| // TODO(dylan-conway): We shouldn't set finalized if coming from _flush |
There was a problem hiding this comment.
im not sure if this todo is blocking
There was a problem hiding this comment.
Updated the comment. It's true we shouldn't set finalized if the caller is _flush, but the field isn't javascript facing and turns out it works the same due to m_ctx.reset() above this.
| void finishCreation(JSC::VM& vm, JSC::JSObject* prototype) | ||
| { | ||
| Base::finishCreation(vm, 2, "Hmac"_s, PropertyAdditionMode::WithStructureTransition); | ||
| // putDirectWithoutTransition(vm, vm.propertyNames->prototype, prototype, JSC::PropertyAdditionMode::WithStructureTransition); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves
HmacandHashto c++ using ncryptoHow did you verify your code works?
Added
test-crypto-hmac.js,test-crypto-hash.js, andtest-crypto-hash-stream-pipe.js