New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node:http2: add throw for ERR_HTTP2_UNSUPPORTED_PROTOCOL #17927

Open

nektro wants to merge 1 commit into main from nektro-patch-57374

Member

nektro commented Mar 6, 2025

this is progress toward test-http2-connect.js but i didnt add it here since there were other issues and i noticed this while inspecting other code


          node:http2: add throw for ERR_HTTP2_UNSUPPORTED_PROTOCOL

023b710

robobun commented Mar 6, 2025 •

edited

Loading

^{Updated 7:11 PM PT - Mar 5th, 2025}

❌ @nektro, your commit 023b710 has 2 failures in Build #12724:

test/cli/install/bun-install-registry.test.ts - 1 failing on 🪟 2019 x64
test/js/third_party/stripe/stripe.test.ts - 1 failing on 🪟 2019 x64-baseline
test/js/third_party/stripe/stripe.test.ts - 1 failing on 🍎 14 aarch64
test/js/third_party/stripe/stripe.test.ts - 1 failing on 🍎 13 aarch64
test/js/third_party/stripe/stripe.test.ts - 1 failing on 🐧 3.20 aarch64
test/js/third_party/stripe/stripe.test.ts - 1 failing on 🪟 2019 x64
test/js/third_party/stripe/stripe.test.ts - 1 failing on 🐧 3.20 x64
test/js/third_party/stripe/stripe.test.ts - 1 failing on 🐧 3.20 x64-baseline

🧪 try this PR locally:

bunx bun-pr 17927

nektro marked this pull request as ready for review

March 6, 2025 03:12

nektro requested a review from cirospaciari

March 6, 2025 03:12

cirospaciari requested changes

View reviewed changes

Member

cirospaciari left a comment

LGTM but needs a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet