Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add test-webstream-encoding-inspect.js #17966

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

node: add test-webstream-encoding-inspect.js #17966

wants to merge 11 commits into from
+193 −51

Conversation

nektro
Copy link
Member

@nektro nektro commented Mar 7, 2025

No description provided.

@robobun
Copy link

robobun commented Mar 7, 2025 •
edited
Loading

Updated 2:18 AM PT - Mar 7th, 2025

✅ @nektro, your commit 6540359766b686eccc50aa9be932487082074926 passed in Build #12839! 🎉

🧪   try this PR locally:

bunx bun-pr 17966

@nektro nektro marked this pull request as ready for review March 7, 2025 20:34
Jarred-Sumner
Jarred-Sumner requested changes Mar 8, 2025
View reviewed changes
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't make these strings. If we need to do this for the custom inspect, then create it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarred-Sumner Jarred-Sumner Jarred-Sumner requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nektro @robobun @Jarred-Sumner