Add bunch of nitpicky micro-optimizations #17967
Open
+100
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nektro
requested changes
Mar 7, 2025
| @@ -299,6 +299,12 @@ static WebCore::BufferEncodingType parseEncoding(JSC::ThrowScope& scope, JSC::JS | |||
| uint32_t validateOffset(JSC::ThrowScope& scope, JSC::JSGlobalObject* globalObject, JSC::JSValue value, JSC::JSValue name, uint32_t min, uint32_t max) | |||
| { | |||
| if (UNLIKELY(!value.isNumber())) return Bun::ERR::INVALID_ARG_TYPE(scope, globalObject, name, "number"_s, value); | |||
| if (value.isInt32()) { | |||
There was a problem hiding this comment.
Suggested change
| if (value.isInt32()) { | |
| if (LIKELY(value.isInt32())) { |
| @@ -308,6 +314,12 @@ uint32_t validateOffset(JSC::ThrowScope& scope, JSC::JSGlobalObject* globalObjec | |||
| uint32_t validateOffset(JSC::ThrowScope& scope, JSC::JSGlobalObject* globalObject, JSC::JSValue value, WTF::ASCIILiteral name, uint32_t min, uint32_t max) | |||
| { | |||
| if (UNLIKELY(!value.isNumber())) return Bun::ERR::INVALID_ARG_TYPE(scope, globalObject, name, "number"_s, value); | |||
| if (value.isInt32()) { | |||
There was a problem hiding this comment.
Suggested change
| if (value.isInt32()) { | |
| if (LIKELY(value.isInt32())) { |
| ASSERT_WITH_MESSAGE(upper.isInt32(), "upper must be an integer. Make sure constants set it to a jsNumber()."); | ||
| auto lower_num = lower.asInt32(); | ||
| auto upper_num = upper.asInt32(); | ||
| if (number_num < lower_num || number_num > upper_num) { |
There was a problem hiding this comment.
Suggested change
| if (number_num < lower_num || number_num > upper_num) { | |
| if (UNLIKELY(number_num < lower_num || number_num > upper_num)) { |
| auto minLength_num = minLength.toNumber(globalObject); | ||
| RETURN_IF_EXCEPTION(scope, {}); | ||
| if (length_num < minLength_num) { | ||
| if (length < minLength_num) { |
There was a problem hiding this comment.
Suggested change
| if (length < minLength_num) { | |
| if (UNLIKELY(length < minLength_num)) { |
| auto minLength_num = minLength.toNumber(globalObject); | ||
| RETURN_IF_EXCEPTION(scope, {}); | ||
| if (length_num < minLength_num) { | ||
| if (length < minLength_num) { |
There was a problem hiding this comment.
Suggested change
| if (length < minLength_num) { | |
| if (UNLIKELY(length < minLength_num)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add bunch of nitpicky micro-optimizations
How did you verify your code works?