[untested] install fish completions based on pkg-config framework #17984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinklepsch
changed the title
|
What errors did you get trying to build? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(presumably) fixes #17855
What does this PR do?
This PR adds an attempt to determine the right directory for installing completions files based on
pkg-config.How did you verify your code works?
I didn't test this code. I tried following
CONTRIBUTING.mdbut couldn't get the build to work despite installing the mentioned dependencies. I'm sharing it so I didn't get into this for nothing 😅 hopefully it helps someone else to fix this issue.