js: de-class-ify node:net.Socket #17997
Draft
+925
−963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (typeof onread !== "object") { | ||
| throw new TypeError("onread must be an object"); | ||
| } | ||
| if (typeof onread.callback !== "function") { |
There was a problem hiding this comment.
should it be validateFunction
| } | ||
| if ( | ||
| // TLSSocket already created a socket and is forwarding it here. This is a private API. | ||
| !(socket && $isObject(socket) && socket instanceof Duplex) && |
There was a problem hiding this comment.
is there a way to avoid the instanceof
| return this; | ||
| }; | ||
|
|
||
| Object.defineProperty(Socket.prototype, "remoteAddress", { |
There was a problem hiding this comment.
are these also read only in node?
| @@ -1470,7 +1452,7 @@ Server.prototype.listen = function listen(port, hostname, onListen) { | |||
| tls.rejectUnauthorized = false; | |||
| } | |||
| } else { | |||
| options.InternalSocketClass = SocketClass; | |||
| options.InternalSocketClass = Socket; | |||
There was a problem hiding this comment.
Is this a real thing? InternalSocketClass? If this was ment as an internal api, can we use a symbol?
| @@ -1726,7 +1708,7 @@ export default { | |||
| isIPv4, | |||
| isIPv6, | |||
| Socket, | |||
| [Symbol.for("::bunternal::")]: SocketClass, | |||
| [Symbol.for("::bunternal::")]: Socket, | |||
There was a problem hiding this comment.
Can we remove this symbol now that we have private symbols?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.