feat(runtime): add process.binding uv/natives/config + make global object properties lazy
#5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave 127 files with test failures on linux-x64-baseline:
|
|
❌ @paperdave 127 files with test failures on linux-x64:
|
paperclover
changed the title
process.bindingprocess.binding uv/natives/config + make global object properties lazy
paperclover
added a commit
to SuperAuguste/bun
that referenced
this pull request
Sep 18, 2023
…lobal object properties lazy (oven-sh#5355) * binding uv * we did that * some more bindings * fix doc * fix uv * yo * static hash table nonsense <3 * huge refactor to the global object i am not ready for merge conflicts * it works part 3 * lose --------- Co-authored-by: Jarred Sumner <[email protected]>
|
Why can't I see this in changelog, wasn't this included in 1.0.3? |
|
it was included in 1.0.3. i guess we forgot to add it to the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
changelog notes:
process.bindinguv/natives/configThis refactors how
process.bindingworks, mainly bringing it into native code. This implements the UV binding (which is simply an error map) which lays out the groundwork to implement the rest of the bindings easily.process.bindingprevents hugo-bin from installing Hugo binary #2891, Closes Segmentation fault with nutjs #2685 by implementingprocess.binding("uv")nativesnot implemented) #4960, Closes process.binding('natives'); error when using dependencyTree module #2254 by implementingprocess.binding("natives")Perhaps before this is merged i will implement some more of these bindings because some are very easy for us to do.