Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: encryption keys location can be specified by the storage implementation #39348

Closed
wants to merge 14 commits into from
Closed

feat: encryption keys location can be specified by the storage implementation #39348

wants to merge 14 commits into from

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 12, 2021 •
edited
Loading

Description

This allows storage implementations to specify the location for encryption keys
https://github.com/owncloud/files_spaces needs this because the space does not belong to a user.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@mmattel
Copy link
Contributor

mmattel commented Oct 12, 2021

I know that the PR is in an early stage, but remember if it gets glose to merge if a docs issue is necessary... 😄

@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch 2 times, most recently from 349f008 to 80be5cb Compare October 19, 2021 14:57
@DeepDiver1975 DeepDiver1975 mentioned this pull request Oct 19, 2021
Open
@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch 3 times, most recently from 89689e7 to 4bc4c36 Compare October 20, 2021 06:50
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiVersions-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33159/85/1

@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch 3 times, most recently from 1a3af2f to 96b5f39 Compare October 20, 2021 14:16
@cdamken
Copy link
Contributor

cdamken commented Oct 22, 2021

I know that the PR is in an early stage, but remember if it gets glose to merge if a docs issue is necessary... 😄

At least to have an appropriate description, to have an easy way to follow what is going to be done

IljaN
IljaN reviewed Oct 22, 2021
View reviewed changes
lib/public/Encryption/IEncryptionModule.php
@@ -66,7 +66,7 @@ public function getDisplayName();
* or if no additional data is needed return a empty array
* @since 8.1.0
*/
public function begin($path, $user, $mode, array $header, array $accessList, $sourceFileOfRename);
public function begin($path, $user, $mode, array $header, array $accessList, $sourceFileOfRename, $fileEncryptionVersion);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break existing implementations of the interface?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically we are probably the only implementors?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - this is a BC break. We need to be careful with releasing this and make sure encryption module is properly release together with it.

@micbar FYI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

necessary change in encryption owncloud/encryption#307

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is E2EE App maybe using this interface?

@DeepDiver1975 DeepDiver1975 changed the title Feat/storage based encryption key location 2 feat: encryption keys location can be specified by the storage implementation Oct 26, 2021
@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review October 26, 2021 07:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

80.2% 80.2% Coverage
0.0% 0.0% Duplication

@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from e9c105e to 15066a3 Compare October 29, 2021 12:03
@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch 3 times, most recently from 830d394 to 592638f Compare December 1, 2021 11:07
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33855/120/1

@DeepDiver1975
Copy link
Member Author

a specific branch of the encryption app is required

Screenshot from 2021-12-01 16-55-54

@mmattel
Copy link
Contributor

mmattel commented Dec 5, 2021

This is docs relevant, please file a docs issue wheh close to merge.

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33941/120/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-3-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33941/172/1

@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from f084e60 to ff502e1 Compare December 15, 2021 09:27
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34037/120/1

@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from ff502e1 to da3fcdc Compare January 11, 2022 15:19
@IljaN IljaN force-pushed the feat/storage-based-encryption-key-location-2 branch from da3fcdc to 74a2bf5 Compare January 11, 2022 15:22
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34278/120/1

DeepDiver1975 and others added 11 commits February 14, 2022 15:39
@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from 74a2bf5 to ec45392 Compare February 14, 2022 14:40
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34637/120/1

@IljaN IljaN changed the base branch from master to release-10.9.1 February 24, 2022 16:25
@IljaN IljaN changed the base branch from release-10.9.1 to master February 24, 2022 16:25
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/34827/120/1

@DeepDiver1975 DeepDiver1975 force-pushed the feat/storage-based-encryption-key-location-2 branch from 49326aa to 43c67b7 Compare March 29, 2022 13:34
@DeepDiver1975 DeepDiver1975 changed the base branch from master to 10.9.x July 27, 2023 07:22
@DeepDiver1975 DeepDiver1975 changed the base branch from 10.9.x to master July 27, 2023 07:22
@phil-davis phil-davis mentioned this pull request Sep 5, 2023
Closed
11 tasks
@DeepDiver1975
Copy link
Member Author

cleaning up - I think this is no longer of anybody's interest

@DeepDiver1975 DeepDiver1975 deleted the feat/storage-based-encryption-key-location-2 branch November 19, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DeepDiver1975 @mmattel @ownclouders @cdamken @IljaN @JammingBen