Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facelift of the ubuntu build instructions #348

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
15 changes: 9 additions & 6 deletions modules/ROOT/pages/appendices/building.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ To get the source dependencies on Debian and Ubuntu, run the following command:
----
sudo apt install qtdeclarative5-dev libinotifytools-dev \
qt5keychain-dev python3-sphinx \
libsqlite3-dev
libsqlite3-dev \
g++ extra-cmake-modules zlib1g-dev pkgconf
----
====

Expand Down Expand Up @@ -287,11 +288,11 @@ To build the most up-to-date version of the Desktop App:
+
[source,bash]
----
git clone git://github.com/owncloud/client.git
git clone https://github.com/owncloud/client.git
cd client
----
+
Note master this default, but you can also check out a tag like v2.5.4
+
By default, `git` clones the development branch called `master`. This branch often works, but this is not guaranteed. If you want to build a stable release or a specific branch, you can use `git checkout <name>` inside the cloned `client` directory to switch to another target. You can find a list of all releases [here](https://github.com/owncloud/client/releases).
+
[source,bash]
----
Expand All @@ -314,14 +315,16 @@ cd client-build
+
[source,console]
----
cmake -DCMAKE_PREFIX_PATH=/opt/ownCloud/qt-5.12.4 -DCMAKE_INSTALL_PREFIX=/Users/path/to/client/../install/ ..
cmake -DCMAKE_PREFIX_PATH=/opt/ownCloud/qt-5.15.2 -DCMAKE_INSTALL_PREFIX=/usr/ ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hack doesn't quite cut it, apparently, since @jnweiger mentioned he needs to install qttools5-dev. Mixing system Qt packages with a custom built Qt doesn't work reliably.

I'm not sure which of our packages ships these dev tools (or if we do at all). All of this is legacy technology. We shouldn't recommend users to build any of our software with our special Qt packages. We do not maintain them for public use.

----
+
Please also check the beginning of ../src/CMakeLists.txt - The version number in `find_package(Qt5 5.xx ...` should match what you have available.
jnweiger marked this conversation as resolved.
Show resolved Hide resolved
jnweiger marked this conversation as resolved.
Show resolved Hide resolved
For client 3.0 or later we use Qt 5.15.2 - for client 2.x we used Qt 5.12.10 or below.
For Linux builds (using QT5 libraries via build-dep) a typical setting is
+
[source,console]
----
-DCMAKE_PREFIX_PATH=/opt/ownCloud/qt-5.12.4/
-DCMAKE_PREFIX_PATH=/opt/ownCloud/qt-5.12.10/
----
+
However, the version number may vary. For Linux builds using system dependencies `-DCMAKE_PREFIX_PATH` is not needed. You must use absolute paths for the `include` and `library` directories.
Expand Down