Feature/issue 201 navigate between channels #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/tungnk123/M3UAndroid into feature/issue-201-navigate-between-channels
oxyroid
reviewed
Dec 22, 2024
Comment on lines
+89
to
+90
| playlist.filterNotNull(), | ||
| channel.filterNotNull() |
There was a problem hiding this comment.
Don't use filterNotNull here. If these upstream flows emit null it means they are cleared. So the adjacentChannels should be cleared as well.
There was a problem hiding this comment.
The issue occurs in the usage of flatmapCombined, where the expected input type is Any, but a value of type Playlist? is being passed.
There was a problem hiding this comment.
Maybe we should adjust the method again.
| when (maskCenterState) { | ||
| Replay, Play, Pause -> { | ||
| MaskCircleButton( | ||
| state = maskState, | ||
| MaskCircleButton(state = maskState, |
There was a problem hiding this comment.
Why i cannot use the reformat feature with these file, when i use it don't move the state to the next line?
I attached the image from my Code Style Settings
There was a problem hiding this comment.
the idea reformation would make mistakes sometimes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.