-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security fixes from the forked repo #32
base: master
Are you sure you want to change the base?
Conversation
sam-caldwell
commented
Jun 5, 2024
- fixed directory traversal detections
- move log4j to slf4j and bump versions
This breaks some of the tests and contains typos, FYI. LOGGER -> logger, a few missing parentheses, and leftover level parameters where they are no longer supported (slf4j's info() does not take a level argument). |
Also the directory traversal "fixes" do not comment sufficiently what you are trying to fix, since the path is an UUID-based path randomly generated with no user-controlled components. The only one that is more obvious is the 'zip slip', but it is also debatable whether the applied fix will cover all cases. I added comments to specific commits but I will summarize those here:
The PR also will fail to build as-is (the unit testing will fail). Not nitpicking here but yara-java needs quite a bit of work and a PR filed without proper verification can mislead people. I'm working with others to bring it up to speed. |