fix(validator-zod): Surface nested errors when validating a union type #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sea-grass is attempting to deploy a commit to the Pablo Alejandro Berganza Campos' projects Team on Vercel. A member of the Team first needs to authorize it. |
sea-grass
force-pushed
the
zod-support-union-types
branch
from
288dbd7 to
96f924b
Compare
pablo-abc
previously approved these changes
Oct 29, 2024
sea-grass
force-pushed
the
zod-support-union-types
branch
from
aa11148 to
f1c9bfe
Compare
|
Hey @pablo-abc, thanks for the review. I saw you'd made some updates to the main branch, so I merged the latest changes. It should be fully up-to-date now. Seems like the PR just needs authorization to run the CI pipeline on Vercel to pass the checks. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248, #290.
Fixes the Zod validator to surface nested
invalid_unionerrors.For existing users of
@felte/validator-zod, validation behaviour is the same. The only difference is that Zod issues with aninvalid_unioncode will now be recursively crawled for their nested issues. Validation works exactly the same, but usage of a union type may now show errors where they weren't shown before.