Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOAPPX-453] Add the new static Appearance profile screen #6573

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Dec 19, 2024

Warning

At the moment the added screen is completely static, with no logic attached.

Short description

This PR adds the new Appearance screen in the Preferences page (under Settings)

List of changes proposed in this pull request

  • Add the new screen with relative routes
  • Add a teaser for the future dark mode release

Preview

Note

The new icons are visible only in the related PR

appearance-screen-last-iteration.mp4

How to test

Go to SettingsPreferencesAppearance

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter Dark mode 🌝 copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. labels Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.83%. Comparing base (dad09b8) to head (8272231).

Files with missing lines Patch % Lines
ts/screens/profile/AppearancePreferenceScreen.tsx 16.66% 5 Missing ⚠️
ts/screens/profile/PreferencesScreen.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6573      +/-   ##
==========================================
+ Coverage   43.18%   49.83%   +6.65%     
==========================================
  Files        1402     1545     +143     
  Lines       29618    32169    +2551     
  Branches     6679     7238     +559     
==========================================
+ Hits        12791    16032    +3241     
+ Misses      16798    16099     -699     
- Partials       29       38       +9     
Files with missing lines Coverage Δ
ts/navigation/ProfileNavigator.tsx 66.66% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
ts/screens/profile/PreferencesScreen.tsx 6.45% <0.00%> (-0.45%) ⬇️
ts/screens/profile/AppearancePreferenceScreen.tsx 16.66% <16.66%> (ø)

... and 362 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad09b8...8272231. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dark mode 🌝 Design System New visual language and reduction of previous UI clutter dont-merge ✋
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants