feat: [IOAPPX-453] Add the new static Appearance profile screen
#6573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
Design System
dmnplb
requested review from
thisisjp,
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6573 +/- ##
==========================================
- Coverage 50.30% 50.29% -0.01%
==========================================
Files 1563 1564 +1
Lines 32510 32518 +8
Branches 7299 7299
==========================================
+ Hits 16353 16354 +1
- Misses 16116 16123 +7
Partials 41 41
Continue to review full report in Codecov by Sentry.
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
…#6590) > [!caution] > This PR depends on: > * #6573 ## Short description This PR enables the new UI overhaul throughout the app. This PR also adds dynamic font selection in the new **Appearance** profile screen. > [!note] > Due to breaking changes introduced with the `5.x` version of the `io-app-design-system` package, this PR also applies changes to some component APIs ## List of changes proposed in this pull request - Update `io-app-design-system` to `5.0.0-7` (pre-release version at the moment) - Add dynamic typeface selection using the `useIONewTypeface` hook - Rename `Experimental Design System` to `Experimental interface` in the Developer section - Remove legacy color palette from `DSColors` - Remove legacy `Badge` component - Remove legacy color references to old UI ### Changes due to API breaking changes - Refactor `useHeaderFirstLevel` by accepting tuples - Change the way IDP assets are rendered: - pagopa/io-app-design-system#403 - [Refactor `ModuleIDP` to accept only `ImageSourcePropType` per color mode](pagopa/io-app-design-system@238a950) - Remove the `size` prop from `Banner` instances - Related: pagopa/io-app-design-system#369 - Remove the `title` prop from `Alert` instances - Related: pagopa/io-app-design-system#370 - Change `Badge` variant names - Related: pagopa/io-app-design-system#372 - Replace `umbrellaNew` Pictogram name with just `umbrella` ### Preview https://github.com/user-attachments/assets/b94f6024-6a50-41da-b701-a392d360ed03 ## How to test Run the app in the local environment. You should see the new UI by default. Change the typeface by going to the new **Appearance** screen --------- Co-authored-by: Jacopo Pompilii <[email protected]> Co-authored-by: Andrea Piai <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
…ngs` screen (#6695) > [!caution] > This PR depends on: > * #6573 ## Short description This PR adds the new typeface selection banner to the **Settings** screen. ## List of changes proposed in this pull request - Add new selector for appearance banner - Delete unsed banner and selector `showProfileBanner` - Move logic to show banner from `ts/features/profileSettings/store/selectors/index.ts` to `ts/features/appearanceSettings/store/selectors/index.ts` - Updated configurations for persistence - Add the new locale strings for the new banner ### Preview | Working of the selector | Flow | | - | - | | <video src="https://github.com/user-attachments/assets/b9a442ba-f9e1-4bd8-96fd-eed1cc89d721"/> | <video src="https://github.com/user-attachments/assets/d6a12762-c7ea-4fc4-bd52-da090f8ba706"/> ### Author(s) @Ladirico @dmnplb ## How to test Run the application and test if everything works as you can see from the preview section --------- Co-authored-by: Jacopo Pompilii <[email protected]> Co-authored-by: Alice Di Rico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
At the moment the added screen is completely static, with no logic attached. The functionality has been added in the following PR:
Short description
This PR adds the new Appearance screen in the Preferences page (under Settings)
List of changes proposed in this pull request
Preview
Note
The new icons are visible only in the related PR
appearance-screen-last-iteration.mp4
How to test
Go to Settings → Preferences → Appearance