-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [IOCOM-2040] Handling of code and pre html blocks in old markdown #6652
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6652 +/- ##
=======================================
Coverage 49.99% 49.99%
=======================================
Files 1544 1544
Lines 32163 32163
Branches 7292 7239 -53
=======================================
Hits 16079 16079
- Misses 16033 16046 +13
+ Partials 51 38 -13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Short description
This PR fixes a problem with the existing markdown component, where text was overflowing or being cut.
Android
iOS
Android
iOS
Android
iOS
List of changes proposed in this pull request
The problem arises when the input markdown string contains:
Such sequences causes the generated html to wrap the text into a
<pre><code>text here</code></pre>
block, that causes either horizontal overflow or vertical cutting (or both).To fix such problem, a custom styling for
pre
andcode
has been added to the markdown's CSS in order to render such blocks as a standard HTML paragraph.How to test
Using the io-dev-api-server, generate a message containing above cases and check that it is rendered properly.