Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPAE-1324] Add analytics tracking for service settings and selected actions #6661

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

adelloste
Copy link
Member

Short description

This PR adds analytics tracking for service settings and selected actions

List of changes proposed in this pull request

  • See commit list

How to test

Ensure that all analytics events are triggered correctly

@adelloste adelloste added the IO-Enti e Servizi IO - Enti e Servizi label Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 49.92%. Comparing base (196e77c) to head (837372d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...services/home/hooks/useServicesHomeBottomSheet.tsx 0.00% 4 Missing ⚠️
...details/components/ServiceDetailsTosAndPrivacy.tsx 0.00% 3 Missing ⚠️
...tures/services/home/screens/ServicesHomeScreen.tsx 0.00% 3 Missing ⚠️
ts/features/services/common/analytics/index.ts 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6661      +/-   ##
==========================================
- Coverage   49.93%   49.92%   -0.01%     
==========================================
  Files        1540     1540              
  Lines       32211    32220       +9     
  Branches     7254     7254              
==========================================
+ Hits        16084    16086       +2     
- Misses      16089    16095       +6     
- Partials       38       39       +1     
Files with missing lines Coverage Δ
.../services/details/screens/ServiceDetailsScreen.tsx 4.16% <ø> (ø)
ts/features/services/common/analytics/index.ts 40.00% <50.00%> (+0.65%) ⬆️
...details/components/ServiceDetailsTosAndPrivacy.tsx 5.88% <0.00%> (ø)
...tures/services/home/screens/ServicesHomeScreen.tsx 3.03% <0.00%> (-0.15%) ⬇️
...services/home/hooks/useServicesHomeBottomSheet.tsx 11.11% <0.00%> (-1.39%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196e77c...837372d. Read the comment docs.

Copy link
Contributor

@giuseppedipinto giuseppedipinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Enti e Servizi IO - Enti e Servizi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants