ci: [IOPLT-924] This PR bumps the xcode version to build a new release #6664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6664 +/- ##
=======================================
Coverage 49.99% 49.99%
=======================================
Files 1544 1544
Lines 32163 32163
Branches 7292 7292
=======================================
Hits 16079 16079
- Misses 16033 16034 +1
+ Partials 51 50 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
… dark and tinted appearances (#6655) > [!important] > The new app icon is only supported in **XCode** `16.x` and above. We need to update it first, in order for the app distribution to work. This change is covered by the related PR. > Depends on #6664 ## Short description This PR updates the main icon app for iOS and adds support for dark and tinted appearances. [We have already tried to update them](#6415), but this change blocked the app distribution at a critical time, the launch of IT Wallet. ## List of changes proposed in this pull request - Add three different icon assets at `1024×1024` size for default, dark and tinted appearances ### Preview https://github.com/user-attachments/assets/e087bb7f-a9ee-40b2-be33-ed246a5b4c9d ## How to test 1. Run the app in the local environment 2. Go to **Customize…** option through long press on the home screen 3. Change visual appearance 4. Check if the optical alignment is correct (for visual designers only 👀) --------- Co-authored-by: Cristiano Tofani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR sets the xcode building version to 16.2. To solve ipa upload issue it was required to update the version of Zendesk sdks used by the App.
List of changes proposed in this pull request
How to test
Check the zendesk integration, nothing should be changed.