Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [IOBP-1170] Align IDPay screen to design requirements #6667

Merged
merged 8 commits into from
Feb 3, 2025

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request is refactoring and improving the consistency of the UI components across various screens in the idpay feature replacing custom layout components with standardized ones from the design system and adjusting the navigation options

List of changes proposed in this pull request

  • Replaced custom ContentWrapper and ButtonSolid components with FooterActions
  • Replaced ContentWrapper, FooterActionsInline, and custom header with IOScrollViewWithLargeHeader and ListItemHeader for a more standardized header and footer layout

How to test

Check refactored screen and ensure everything work properly

Preview

IDPAY_UNSUBSCRIPTION_CONFIRMATION IDPAY_UNSUBSCRIPTION_CONFIRMATION modal IDPAY_DETAILS_BENEFICIARY modal IDPAY_PAYMENT_CODE_INPUT IDPAY_PAYMENT_AUTHORIZATION
Screenshot 2025-01-31 at 13 44 16 Screenshot 2025-01-31 at 13 45 04 Screenshot 2025-01-31 at 13 43 25 Screenshot 2025-01-31 at 13 46 56 Screenshot 2025-01-31 at 13 47 51

@LeleDallas LeleDallas added IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti labels Jan 31, 2025
@LeleDallas LeleDallas self-assigned this Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@thisisjp
Copy link
Contributor

@LeleDallas in IDPAY_PAYMENT_AUTHORIZATION the icon next to the section heading must have the same color as the text (for future reference: if the icon is a button it's blue, if it's just decorative it's light grey) ;)

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 49.98%. Comparing base (63ff6c2) to head (e24c6fc).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ay/payment/screens/IDPayPaymentCodeInputScreen.tsx 0.00% 4 Missing ⚠️
...ption/screens/UnsubscriptionConfirmationScreen.tsx 0.00% 3 Missing ⚠️
...ayment/screens/IDPayPaymentAuthorizationScreen.tsx 0.00% 2 Missing ⚠️
...dpay/details/components/InitiativeRulesInfoBox.tsx 0.00% 1 Missing ⚠️
...pay/onboarding/screens/PDNDPrerequisitesScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6667   +/-   ##
=======================================
  Coverage   49.98%   49.98%           
=======================================
  Files        1544     1544           
  Lines       32164    32159    -5     
  Branches     7291     7294    +3     
=======================================
- Hits        16077    16075    -2     
+ Misses      16049    16045    -4     
- Partials       38       39    +1     
Files with missing lines Coverage Δ
ts/features/idpay/payment/navigation/navigator.tsx 37.50% <ø> (ø)
...ures/idpay/unsubscription/navigation/navigator.tsx 66.66% <ø> (ø)
...ubscription/screens/UnsubscriptionResultScreen.tsx 6.66% <ø> (-5.84%) ⬇️
...dpay/details/components/InitiativeRulesInfoBox.tsx 27.27% <0.00%> (ø)
...pay/onboarding/screens/PDNDPrerequisitesScreen.tsx 5.26% <0.00%> (ø)
...ayment/screens/IDPayPaymentAuthorizationScreen.tsx 12.50% <0.00%> (ø)
...ption/screens/UnsubscriptionConfirmationScreen.tsx 6.66% <0.00%> (+0.41%) ⬆️
...ay/payment/screens/IDPayPaymentCodeInputScreen.tsx 6.66% <0.00%> (-5.10%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2a193...e24c6fc. Read the comment docs.

@LeleDallas
Copy link
Contributor Author

@LeleDallas in IDPAY_PAYMENT_AUTHORIZATION the icon next to the section heading must have the same color as the text (for future reference: if the icon is a button it's blue, if it's just decorative it's light grey) ;)

Thanks for reporting that!
I kept it blue because it was like this before... I'll now update it to light grey

@LeleDallas
Copy link
Contributor Author

@thisisjp addressed here a8e0761
Screenshot 2025-01-31 at 14 14 57

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeleDallas LeleDallas added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit ce74487 Feb 3, 2025
22 checks passed
@LeleDallas LeleDallas deleted the IOBP-1170-idpay-design-align branch February 3, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants