-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [IOBP-1170] Align IDPay screen to design requirements #6667
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
@LeleDallas in IDPAY_PAYMENT_AUTHORIZATION the icon next to the section heading must have the same color as the text (for future reference: if the icon is a button it's blue, if it's just decorative it's light grey) ;) |
Thanks for reporting that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This pull request is refactoring and improving the consistency of the UI components across various screens in the
idpay
feature replacing custom layout components with standardized ones from the design system and adjusting the navigation optionsList of changes proposed in this pull request
ContentWrapper
andButtonSolid
components withFooterActions
ContentWrapper
,FooterActionsInline
, and custom header withIOScrollViewWithLargeHeader
andListItemHeader
for a more standardized header and footer layoutHow to test
Check refactored screen and ensure everything work properly
Preview
IDPAY_UNSUBSCRIPTION_CONFIRMATION
IDPAY_UNSUBSCRIPTION_CONFIRMATION
modalIDPAY_DETAILS_BENEFICIARY
modalIDPAY_PAYMENT_CODE_INPUT
IDPAY_PAYMENT_AUTHORIZATION