-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(IT Wallet): [SIW-1942] Use Skia
for IT Wallet credential card effects based on credential status
#6668
refactor(IT Wallet): [SIW-1942] Use Skia
for IT Wallet credential card effects based on credential status
#6668
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Skia
for IT Wallet credential card effects based on credential status
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6668 +/- ##
=======================================
Coverage 49.99% 49.99%
=======================================
Files 1544 1539 -5
Lines 32163 32169 +6
Branches 7292 7244 -48
=======================================
+ Hits 16079 16082 +3
- Misses 16033 16049 +16
+ Partials 51 38 -13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR adds Skia filter to IT Wallet credential cards removing the need to have image assets for each credential status.
List of changes proposed in this pull request
AnimatedImage
component with Skia'sImage
andBlendColor
components to add "faded" and "greyscale" effects to credential card background imagesItwCredentialCard
componentHow to test
You can test the cards component on your wallet or, alternatively, in Profile → Design System → Cards → Documents
Check that everything works as expected on both Android and iOS devices.