Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(IT Wallet): [SIW-1942] Use Skia for IT Wallet credential card effects based on credential status #6668

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Jan 31, 2025

Short description

This PR adds Skia filter to IT Wallet credential cards removing the need to have image assets for each credential status.

List of changes proposed in this pull request

  • Removed unnecessary assets
  • Replaced AnimatedImage component with Skia's Image and BlendColor components to add "faded" and "greyscale" effects to credential card background images
  • Refactored ItwCredentialCard component

How to test

You can test the cards component on your wallet or, alternatively, in Profile → Design System → Cards → Documents
Check that everything works as expected on both Android and iOS devices.

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@mastro993 mastro993 marked this pull request as ready for review January 31, 2025 14:33
@mastro993 mastro993 changed the title refactor(IT Wallet): [SIW-1942] Use Skia for IT Wallet cards effects based on credential status refactor(IT Wallet): [SIW-1942] Use Skia for IT Wallet credential card effects based on credential status Jan 31, 2025
@mastro993 mastro993 self-assigned this Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.99%. Comparing base (dd98d71) to head (fbd7a98).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...on/components/ItwCredentialCard/CardBackground.tsx 81.25% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6668   +/-   ##
=======================================
  Coverage   49.99%   49.99%           
=======================================
  Files        1544     1539    -5     
  Lines       32163    32169    +6     
  Branches     7292     7244   -48     
=======================================
+ Hits        16079    16082    +3     
- Misses      16033    16049   +16     
+ Partials       51       38   -13     
Files with missing lines Coverage Δ
...mponents/ItwCredentialCard/DigitalVersionBadge.tsx 95.00% <100.00%> (ø)
...components/ItwCredentialCard/ItwCredentialCard.tsx 100.00% <100.00%> (ø)
...on/components/ItwCredentialCard/CardBackground.tsx 81.25% <81.25%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd98d71...fbd7a98. Read the comment docs.

Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 added this pull request to the merge queue Feb 4, 2025
Merged via the queue into master with commit e7955cb Feb 4, 2025
22 checks passed
@mastro993 mastro993 deleted the SIW-1942-handle-itw-cards-statuses-with-skia branch February 4, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants