Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-1162] Add missing a11y label in PAYMENTS_HOME #6669

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request includes accessibility improvements to the PAYMENTS_HOME screen.

List of changes proposed in this pull request

  • Added missing accessibilityLabel to endElement prop

How to test

  • Using a real device 📱, go to the PAYMENTS_HOME screen
  • Turn on the TalkBack accessibility tool
  • Tap Aggiungi and check if it is read correctly.
  • Tap Vedi tutte and check if it is read correctly.

@LeleDallas LeleDallas added a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti labels Jan 31, 2025
@LeleDallas LeleDallas self-assigned this Jan 31, 2025
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.99%. Comparing base (75d27a4) to head (c9f7577).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6669   +/-   ##
=======================================
  Coverage   49.99%   49.99%           
=======================================
  Files        1544     1544           
  Lines       32163    32163           
  Branches     7241     7242    +1     
=======================================
  Hits        16079    16079           
  Misses      16045    16045           
  Partials       39       39           
Files with missing lines Coverage Δ
...s/home/components/PaymentsHomeTransactionsList.tsx 77.77% <ø> (ø)
...ts/home/components/PaymentsHomeUserMethodsList.tsx 80.76% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75d27a4...c9f7577. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Activities related to accessibility IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants