Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1156] Include additional params in doneCb, if any #153

Merged
merged 6 commits into from
Dec 1, 2023
Merged

[#IOPID-1156] Include additional params in doneCb, if any #153

merged 6 commits into from
Dec 1, 2023

Conversation

gquadrati
Copy link
Contributor

List of Changes

See commit history

Motivation and Context

This PR enables the possibility to use additional params in done callback too (now it's allowed in acs callback).

How Has This Been Tested?

Unit test, manual tests with io-mock

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1156

@gquadrati gquadrati mentioned this pull request Nov 27, 2023
Merged
6 tasks
arcogabbo
arcogabbo reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@arcogabbo arcogabbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, however I believe we can get rid of the inference error with this changes. what do you think @gquadrati? unfortunately, Omit type coming from the spread operator still forces us to cast with as T

src/strategy/spid.ts Outdated Show resolved Hide resolved
src/strategy/spid.ts Outdated Show resolved Hide resolved
src/utils/saml.ts Outdated Show resolved Hide resolved
src/utils/saml.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gquadrati
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@gquadrati gquadrati requested a review from arcogabbo November 30, 2023 17:23
@gquadrati gquadrati merged commit 61c18e9 into master Dec 1, 2023
4 checks passed
@gquadrati gquadrati deleted the IOPID-1156--return-extraParams-in-doneCb branch December 1, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcogabbo arcogabbo arcogabbo approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner

@gunzip gunzip Awaiting requested review from gunzip gunzip is a code owner

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner

@AleDore AleDore Awaiting requested review from AleDore AleDore is a code owner

@balanza balanza Awaiting requested review from balanza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gquadrati @arcogabbo