Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOPID-1612, #IOPID-1513] SAMLResponse missing errorMessage #156

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

arcogabbo
Copy link
Contributor

@arcogabbo arcogabbo commented Mar 29, 2024

List of Changes

  • custom errorMessage in case SAMLResponse is missing

Motivation and Context

At the moment, the error for a SAMLResponse missing is misleading and it cames from the passport-saml library that tries to construct an AuthNRequest if it doesn't find a proper SAMLResponse in body. This change will prevent that scenario to happen, returning a proper errorMessage so it can be tracked in our dashboards.

How Has This Been Tested?

unit tests, integration test via io-mock on io-backend

on [email protected] with this io-spid-commons build injected:

curl --insecure -X POST https://localhost:8000/assertionConsumerService

## Found. Redirecting to https://localhost:8000/error.html?errorMessage=Missing%20SAMLResponse%20in%20ACS

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

github-actions bot commented Mar 29, 2024

Jira Pull Request Link

This Pull Request refers to Jira issues:
- Link to IOPID-1612
- Link to IOPID-1513

@arcogabbo arcogabbo marked this pull request as ready for review April 2, 2024 07:29
@arcogabbo arcogabbo changed the title [#IOPID-1612] SAMLResponse missing errorMessage [#IOPID-1612, #IOPID-1513] SAMLResponse missing errorMessage Apr 2, 2024
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@arcogabbo arcogabbo merged commit 187cfa5 into master Apr 12, 2024
6 checks passed
@arcogabbo arcogabbo deleted the IOPID-1612--samlresponse-missing-error branch April 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants