Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mock ErrorDecoder in ConjureBodySerDeTest #2459

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

mpritham
Copy link
Contributor

@mpritham mpritham commented Jan 8, 2025

Before this PR

When testing ConjureBodySerDe, we mock the function calls to ErrorEncoder. When implementing #2443, I introduce a replacement for ErrorDecoder. I would like to be able to validate that we don't have regressions in the current error handling logic and not mocking ErrorDecoder will help: I can validate that the logic in ErrorDecoder is still valid with my changes in #2443 where I replace logic in ErrorDecoder with calls to a delegate EndpointErrorDecoder.

After this PR

==COMMIT_MSG==
Don't mock ErrorDecoder in ConjureBodySerDeTest
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Jan 8, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Don't mock ErrorDecoder in ConjureBodySerDeTest

Check the box to generate changelog(s)

  • Generate changelog entry

@mpritham mpritham requested a review from carterkozak January 8, 2025 18:34
@mpritham mpritham self-assigned this Jan 8, 2025
@bulldozer-bot bulldozer-bot bot merged commit eec4e86 into develop Jan 8, 2025
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the pm/update-conjure-body-serde-test branch January 8, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants