Ea.cache #1183
Merged
Ea.cache #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
force-pushed
the
ea.cache
branch
2 times, most recently
from
15b9e6f to
430b58d
Compare
ssanjay1
reviewed
Feb 18, 2025
packages/api/src/OsdkObjectFrom.ts
Outdated
| @@ -206,7 +206,7 @@ export namespace Osdk { | |||
|
|
|||
| readonly $clone: <NEW_PROPS extends PropertyKeys<Q>>( | |||
| updatedObject?: | |||
| | Osdk.Instance<Q, any, NEW_PROPS> | |||
There was a problem hiding this comment.
this is the fix to make intellisense work right
There was a problem hiding this comment.
Will take it out for safety
ssanjay1
reviewed
Feb 18, 2025
| @@ -15,3 +15,11 @@ | |||
| */ | |||
|
|
|||
| export { augment } from "../object/fetchPage.js"; | |||
|
|
|||
| // THIS IS NOT THE FINAL NAME DO NOT SHIP LIKE THIS | |||
There was a problem hiding this comment.
It's fine to bikeshed names while in unstable though right?
ericanderson
force-pushed
the
ea.cache
branch
from
2d9e142 to
67de9ef
Compare
ericanderson
force-pushed
the
ea.cache
branch
from
990b618 to
17a923c
Compare
nihalbhatnagar
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.