Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multigpu test #260

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Fix multigpu test #260

merged 2 commits into from
Mar 4, 2025

Conversation

ksikka
Copy link
Collaborator

@ksikka ksikka commented Mar 3, 2025

No description provided.

@themattinthehatt
Copy link
Collaborator

thanks for looking into this - any idea why it was working previously?

@ksikka
Copy link
Collaborator Author

ksikka commented Mar 3, 2025

Of course. I recently tested that multigpu tests pass in axon, then updated the srun to have gres:2 to allow multigpu tests to run in CI.

However sometime after that, I must have run pip install lightning-pose from pypi, not using -e, and this breaks the multigpu tests as the subprocess call to python script/train_hydra.py resolves import lightning_pose from the pip installed lightning pose, not the root of the git repo that you run pytest in. Pytest uses the prepend method described here, but it does not extend to subprocesses:
https://docs.pytest.org/en/7.1.x/explanation/pythonpath.html

@themattinthehatt themattinthehatt merged commit 0abaa2f into paninski-lab:main Mar 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants