Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp ban plugin known issue #6247

Closed
nullvariable opened this issue Feb 10, 2021 · 3 comments · Fixed by #6272
Closed

wp ban plugin known issue #6247

nullvariable opened this issue Feb 10, 2021 · 3 comments · Fixed by #6272
Labels
Source: Pantheor Contribution from within Pantheon, unspecified team Topic: WordPress WordPress-specific Type: New Content Request for or PR containing new content to existing page

Comments

@nullvariable
Copy link
Contributor

Re: WordPress Plugins with known issues

Priority: Low

Issue Description

The WP Ban plugin should be added to the list
https://wordpress.org/plugins/wp-ban/
This plugin will ban traffic to uncached pages, but it uses a 200 status code when returning those pages which causes the platform to cache the banned message for future users.

@alexfornuto alexfornuto added Source: Pantheor Contribution from within Pantheon, unspecified team Type: New Content Request for or PR containing new content to existing page Topic: WordPress WordPress-specific labels Feb 11, 2021
@EdwardAngert EdwardAngert self-assigned this Feb 23, 2021
@EdwardAngert
Copy link
Contributor

thanks @nullvariable!
I saw the option to customize a ban message, but I didn't see anything in the options screenshots that makes it seem like it can be set to return a 400-level code instead. I'd love to provide a "solution" along with the issue, but it seems more like a "heads up, this won't do what you think it might do"
pr incoming

@nullvariable
Copy link
Contributor Author

lesterchan/wp-ban#10 (comment)

the solution I would recommend is making a PR upstream or waiting for the plugin author to offer additional options

@nullvariable
Copy link
Contributor Author

for now what you've got there warning folks that the plugin may end up being cached and telling all visitors they're banned is all that I'd recommend from our side

@EdwardAngert EdwardAngert removed their assignment Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Pantheor Contribution from within Pantheon, unspecified team Topic: WordPress WordPress-specific Type: New Content Request for or PR containing new content to existing page
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants