list wp-ban as known issue due to 200-level responses #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The copy is all factually correct but potentially missing the most important part. Because the request is 200, the global CDN could save that "you are blocked" page and serves it up to anyone else visiting that page. |
well that's not good at all |
EdwardAngert
commented
Feb 23, 2021
| @@ -1050,7 +1050,7 @@ ___ | |||
|
|
|||
| <ReviewDate date="2021-02-23" /> | |||
|
|
|||
| **Issue:** This plugin works on the platform but might not perform the function that users expect. WP-Ban returns a [200-level](/metrics#available-metrics) response code to banned IPs. These responses are cached and count towards Site Visits. | |||
| **Issue:** WP-Ban returns a [200-level](/metrics#available-metrics) response code to banned IPs. These responses are cached and count towards Site Visits. In addition, the Pantheon [Global CDN](/global-cdn) may cache the result as successful, leading future visitors to think they've also been banned. | |||
There was a problem hiding this comment.
@davidneedham - I added the cache note and removed the "well, it does still work" to dissuade users. Does that seem like it's better described?
carolyn-shannon
added
Type: New Content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6247
Summary
WordPress Plugins and Themes with Known Issues - WP-Ban bans traffic to uncached pages, but it uses a 200 status code when returning those pages which causes the platform to cache the banned message for future users and count the traffic as a Site Visit.
Remaining Work
The following changes still need to be completed:
Post Launch
Do not remove - To be completed by the docs team upon merge: