-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine): cleanup leaked context #13749
Open
fgimenez
wants to merge
5
commits into
main
Choose a base branch
from
fgimenez/cleanup-leaked-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
added
A-blockchain-tree
Related to sidechains, reorgs and pending blocks
C-perf
A change motivated by improving speed, memory usage or disk footprint
labels
Jan 9, 2025
shekhirin
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works
fgimenez
force-pushed
the
fgimenez/cleanup-leaked-context
branch
2 times, most recently
from
January 10, 2025 18:15
85afa6f
to
fbb8a38
Compare
fgimenez
force-pushed
the
fgimenez/cleanup-leaked-context
branch
from
January 12, 2025 15:33
7ebcaa8
to
227dc8b
Compare
CodSpeed Performance ReportMerging #13749 will degrade performances by 15.18%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-blockchain-tree
Related to sidechains, reorgs and pending blocks
C-perf
A change motivated by improving speed, memory usage or disk footprint
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the introduction on
std::thread::scope
for creatingStateRootTask
, we started usingBox::leak
to keep alive values required to return and move around the state hook closure. The changes in this PR clean up the leaked data after it has been used, will prevent warnings like: