perf(op-receipts): reuse l1_block_info for multiple receipts
#13781
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-rise
commented
Jan 13, 2025
| Ok(OpReceiptBuilder::new( | ||
| &self.inner.eth_api.provider().chain_spec(), | ||
| tx, | ||
| meta, | ||
| receipt, | ||
| &receipts, | ||
| l1_block_info.clone(), |
There was a problem hiding this comment.
Main motivation as L1BlockInfo is 312 bytes and this clone can scale to 100k+ transactions/block for high-performance chains.
mattsse
approved these changes
Jan 13, 2025
Comment on lines
+63
to
+66
| // We must clear this cache as different L2 transactions can have different | ||
| // L1 costs. A potential improvement here is to only clear the cache if the | ||
| // new transaction input has changed, since otherwise the L1 cost wouldn't. | ||
| l1_block_info.clear_tx_l1_cost(); |
There was a problem hiding this comment.
-.-
I knew that introducing this behaviour would end causing problems somewhere
There was a problem hiding this comment.
It's a dangerous but manageable one 🙏.
mattsse
added
A-rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows reusing
L1BlockInfowhen building OP receipts for multiple transactions (of the same block). Came across this as we built fast pre-confirmations for users 🙏.