Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Push adapter not loading on some versions of Node 22 #9525

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 10, 2025

Closes: #9517

Backport to Parse Server 7 of #9524

Copy link

parse-github-assistant bot commented Jan 10, 2025

Thanks for opening this pull request!

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (4ac8aef) to head (1ac6348).
Report is 1 commits behind head on release-7.x.x.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-7.x.x    #9525      +/-   ##
=================================================
+ Coverage          93.15%   93.50%   +0.34%     
=================================================
  Files                186      186              
  Lines              14810    14804       -6     
=================================================
+ Hits               13796    13842      +46     
+ Misses              1014      962      -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza
Copy link
Member

mtrezza commented Jan 11, 2025

Why do the tests here fail? They didn't in https://github.com/parse-community/parse-server/pull/9520/checks.

@mtrezza mtrezza changed the title fix: Push adapter not loading on Node 22 (release 7.x.x) fix: Push adapter not loading on some versions of Node 22 Jan 11, 2025
@dblythy dblythy requested a review from a team January 12, 2025 01:03
@mtrezza mtrezza merged commit 5447c22 into parse-community:release-7.x.x Jan 12, 2025
27 of 30 checks passed
@mtrezza mtrezza removed the request for review from a team January 12, 2025 01:10
@dblythy dblythy deleted the fix-adapters-release branch January 12, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants