Fix mypy with Torch #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablolh
force-pushed
the
plh/mypy_torch
branch
2 times, most recently
from
e156d40 to
b180d32
Compare
pablolh
force-pushed
the
plh/mypy_torch
branch
2 times, most recently
from
3b0a64f to
1706a3f
Compare
sgrava
reviewed
Jan 27, 2025
sgrava
reviewed
Jan 27, 2025
murogrande
reviewed
Jan 28, 2025
Add torch as mypy dependency, which revealed lot of new typing errors to be fixed.
pablolh
force-pushed
the
plh/mypy_torch
branch
from
1706a3f to
cb181a5
Compare
sgrava
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add torch as mypy dependency, which revealed lot of new typing errors to be fixed.