Add performance section to settings and add option to disable highlig…

…hts (#89) * menu tweaks * cleanup settings menu * toggle highlights * clear highlights when u turn them off * fix load and clean up settings * clean up * fix layout of long labels * clean up settings
pastagang · Feb 2, 2025 · be72c4f · be72c4f
1 parent a283520
commit be72c4f
Show file tree

Hide file tree

Showing 6 changed files with 183 additions and 126 deletions.
diff --git a/index.html b/index.html
@@ -167,53 +167,70 @@ <h3>User settings</h3>
               </p>
             </section>
             <section>
-              <h3>Panel types</h3>
+              <h3>Nudel appearance</h3>
               <p>
                 <label>
-                  <input type="checkbox" id="settings-strudel-enabled" />
-                  Enable strudel
+                  Layout
+                  <select id="settings-panel-mode">
+                    <option value="scroll">Scroll layout</option>
+                    <option value="boxed">Boxed layout</option>
+                    <option value="tabbed">Tabbed layout</option>
+                  </select>
                 </label>
               </p>
               <p>
                 <label>
-                  <input type="checkbox" id="settings-hydra-enabled" />
-                  Enable hydra
+                  <input type="checkbox" id="settings-zen-mode" />
+                  Minimal user interface
                 </label>
               </p>
+            </section>
+            <hr />
+            <section>
+              <h2>Performance</h2>
+              <p>
+                To make nudel run better on your machine, try changing these settings. Some of them turn certain things
+                off, which may help other things to run better.
+              </p>
+              <br />
+              <h3>Panel types</h3>
+              <p>These settings control which types of panels will run for you.</p>
               <p>
                 <label>
-                  <input type="checkbox" id="settings-shader-enabled" />
-                  Enable shader
+                  <input type="checkbox" id="settings-strudel-enabled" />
+                  Enable strudel (sound)
                 </label>
               </p>
               <p>
                 <label>
                   <input type="checkbox" id="settings-kabelsalat-enabled" />
-                  Enable kabelsalat
+                  Enable kabelsalat (sound)
                 </label>
               </p>
-            </section>
-            <section>
-              <h3>Nudel appearance</h3>
               <p>
                 <label>
-                  Layout
-                  <select id="settings-panel-mode">
-                    <option value="scroll">Scroll layout</option>
-                    <option value="boxed">Boxed layout</option>
-                    <option value="tabbed">Tabbed layout</option>
-                  </select>
+                  <input type="checkbox" id="settings-hydra-enabled" />
+                  Enable hydra (visuals)
                 </label>
               </p>
               <p>
                 <label>
-                  <input type="checkbox" id="settings-zen-mode" />
-                  Minimal user interface
+                  <input type="checkbox" id="settings-shader-enabled" />
+                  Enable shader (visuals)
+                </label>
+              </p>
+              <br />
+              <h3>Panel settings</h3>
+              <p>
+                <label>
+                  <input type="checkbox" id="settings-strudel-highlights-enabled" />
+                  Enable strudel highlights
                 </label>
               </p>
             </section>
+            <hr />
             <section>
-              <h3>Editor settings</h3>
+              <h2>Editor settings</h2>
               <p>
                 <label>
                   <input type="checkbox" id="settings-line-numbers" />
@@ -235,13 +252,13 @@ <h3>Editor settings</h3>
               <p>
                 <label>
                   <input type="checkbox" id="settings-track-cursors" />
-                  Track Remote Cursors
+                  Track remote cursors (requires reload) (only advised for boxed layout)
                 </label>
               </p>
               <p>
                 <label>
                   <input type="checkbox" id="settings-vim-mode" />
-                  Vim keybindings
+                  Vim keybindings (requires reload)
                 </label>
               </p>
               <p>
@@ -261,7 +278,9 @@ <h3>Editor settings</h3>
               </p>
             </section>
             <section class="development">
-              <h3>Development settings</h3>
+              <hr />
+              <br />
+              <h2>Development settings</h2>
               <p>
                 <label>
                   <input type="checkbox" id="settings-welcome-message" />
@@ -271,7 +290,7 @@ <h3>Development settings</h3>
               <p>
                 <label>
                   <input type="checkbox" id="settings-strudel-autocomplete" />
-                  Strudel Autocomplete 🧪
+                  Strudel auto-complete (experimental)
                 </label>
               </p>
             </section>

diff --git a/panels/strudel.html b/panels/strudel.html
@@ -17,7 +17,13 @@
 
       const strudel = new StrudelSession({
         onError: (...args) => send('onError', args),
-        onHighlight: (docId, phase, haps) => highlightMiniLocations(editorViews.get(docId), phase, haps),
+        onHighlight: (docId, phase, haps) => {
+          const settings = window.parent.getSettings();
+          if (!settings.strudelHighlightsEnabled) {
+            return;
+          }
+          highlightMiniLocations(editorViews.get(docId), phase, haps);
+        },
         onUpdateMiniLocations: (docId, miniLocations) => updateMiniLocations(editorViews.get(docId), miniLocations),
       });
 

diff --git a/src/editor.js b/src/editor.js
@@ -300,7 +300,9 @@ export class PastaMirror {
     }); */
   }
 
-  updateExtensions(settings, appliedSettings) {
+  updateExtensions({ previous, next }) {
+    const appliedSettings = previous;
+    const settings = next;
     const keys = Object.keys(this.extensions);
     for (let index in keys) {
       const key = keys[index];

diff --git a/src/main.js b/src/main.js
@@ -204,3 +204,10 @@ document.getElementById('remove-pane-button').addEventListener('click', () => {
   const documents = session.getDocuments();
   session.setActiveDocuments([...documents.map((doc) => ({ id: doc.id, target: doc.target })).slice(0, -1)]);
 });
+
+// highlights
+export function clearStrudelHighlights() {
+  for (const view of pastamirror.editorViews.values()) {
+    updateMiniLocations(view, []);
+  }
+}