Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the tool menu dynamic #29

Open
wants to merge 3 commits into
base: 1.3.0
Choose a base branch
from

Conversation

P-Jelle
Copy link

@P-Jelle P-Jelle commented May 28, 2024

name: Pull request
about: Request to have code merged into FreePaint
title: "Made the tool menu dynamic"

Checklist
In order for your pull request to be considered, please follow the checklist below. Ensure you have not deleted any points but instead checked them by replacing [ ] with [x] or clicking on the boxes.

  • I have given my pull request a descriptive title, written in present tense. It begins with a verb and is not vague.
    • For instance, a bad title would be "Make the menu change." Which menu? What do you define as a "changing menu"? Perhaps a better name would be "Change settings title based on tool name".
  • My pull request contains small, regular commits, named to the same standard as the PR itself.
    • A good rule of thumb is if you introduce a Java class file, or multiple files, that your PR needs separate commits. I need to see your thinking in action so it's easier to follow and verify.
  • My pull request focuses on one feature or bug.
    • A common mistake can be made when one uses the same fork for multiple pull requests. Make sure your PR has only the commits you need to merge your specific feature.
  • My PR is based off of and is merging with the branch for the latest development version code of FreePaint (for instance, if the latest stable version is v1.5.0, instead of merging to main, I am merging to 1.3.0.
    • If such a branch does not exist, please notify the maintainer.
  • If my PR introduces a feature, I explain in detail what this feature does.
    • Try to include screenshots or even videos. You have to explain what features you are planning on adding so that the maintainer or community members don't have to run your PR to understand your goal.
    • If you're changing a menu, for instance, include screenshots of what you've changed.

Screenshots

@P-Jelle P-Jelle closed this May 30, 2024
@P-Jelle P-Jelle reopened this May 30, 2024
@pastthepixels
Copy link
Owner

I wrote this on your other PR but because the same thing applies here I'll paste it:

Sorry I didn't make a PR template earlier - please follow the checklist here https://github.com/pastthepixels/FreePaint/blob/main/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Additionally since I use the main branch for stable releases, I've made a 1.3.0 branch; please rebase and try to merge to that instead.

Also, please add to your PR description what you mean by making the tool menu dynamic. (You don't need to have screenshots but they help!) I have some plans on what I want FreePaint's UI to look like (also undocumented right now but I'm working on that), plus for Android some seemingly easy solutions become very hard to maintain due to Android's UI libraries being all over the place, so I might be able to merge this code as-is or we might have to come up with a different solution.

Thanks!

@P-Jelle P-Jelle changed the title Tool menu is now dynamic Made the tool menu dynamic Jun 13, 2024
@P-Jelle P-Jelle changed the base branch from main to 1.3.0 June 13, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants