chore: migrate from Moko to JetBrains Compose Multiplatform resources #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeyls
force-pushed
the
refactor/jetbrains_multiplatform_resources
branch
2 times, most recently
from
f086c13 to
251d04e
Compare
martinbonnin
force-pushed
the
refactor/jetbrains_multiplatform_resources
branch
from
251d04e to
0bc1f26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like someone to test this branch on iOS before merging because it can have a big impact.
Also note that even after this migration, the app will still include the Moko Resources library because it's used by the current version of the OpenFeedback SDK. Both can coexist without issues on Android, but this has to be confirmed for iOS.
If everything works on iOS this branch can be merged, otherwise we keep it around until problems are fixed or OpenFeedback provides a compatible version.
In the future, we should migrate to a newer version of OpenFeedback that doesn't use Moko, but this must be carefully tested because: