Release 1.1.2

Controller/Payment/Notifications.php

@@ -118,7 +118,10 @@ public function execute()
             );
             $this->getResponse()->setHttpResponseCode(400);
         } catch (OrderHasBeenAlreadyPaidException $exception) {
-            $this->logger->info($exception->getMessage() . ' Skip processing the notification.');
+            $this->logger->info(
+                $exception->getMessage() . ' Skip processing the notification.',
+                $notificationData
+            );
             $this->getResponse()->setHttpResponseCode(200);
         }
     }

Helper/NotificationProcessor.php

@@ -90,9 +90,12 @@ public function process($paymentId, $status, $externalId)
 
         $this->logger->debug(
             "Current order state",
-            array_merge($this->loggerContext, [
-                'currentStatus' => $orderPaymentStatus
-            ])
+            array_merge(
+                [
+                    'currentStatus' => $orderPaymentStatus
+                ],
+                $this->loggerContext
+            )
         );
 
         if ($finalPaymentStatus) {
@@ -212,7 +215,7 @@ private function paymentRejected()
             $this->order->addCommentToStatusHistory($message);
         }
 
-            $this->order->getPayment()->setIsClosed(true);
+        $this->order->getPayment()->setIsClosed(true);
     }
 
     /**
@@ -250,6 +253,7 @@ private function isCorrectStatus($previousStatus, $nextStatus): bool
     {
         $paymentStatusFlow = [
             Status::STATUS_NEW => [
+                Status::STATUS_NEW,
                 Status::STATUS_PENDING,
                 Status::STATUS_ERROR,
                 Status::STATUS_EXPIRED,

Model/Exception/OrderHasBeenAlreadyPaidException.php

@@ -11,7 +11,7 @@
  */
 class OrderHasBeenAlreadyPaidException extends Exception
 {
-    const EXCEPTION_MESSAGE = 'Order %s has been already paid in %s.';
+    const EXCEPTION_MESSAGE = 'An order %s has been already paid in %s.';
 
     public function __construct($orderId, $paymentId)
     {

Test/Unit/Gateway/Response/Payment/AuthorizationHandlerTest.php

@@ -34,6 +34,7 @@ public function testHandle()
             PaymentField::PAYMENT_ID_FIELD_NAME => 'testPaymentId',
             PaymentField::STATUS_FIELD_NAME => 'NEW',
             PaymentField::REDIRECT_URL_FIELD_NAME => 'testRedirectUrl',
+            PaymentField::EXTERNAL_ID_FIELD_NAME => 'testExternalId',
         ];
 
         $paymentDO->expects(static::atLeastOnce())

composer.json

@@ -2,7 +2,7 @@
   "name": "pay-now/paynow-magento2",
   "description": "Module for Paynow payments",
   "type": "magento2-module",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "license": "MIT",
   "keywords": [
     "paynow",

etc/module.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Paynow_PaymentGateway" setup_version="1.1.1">
+    <module name="Paynow_PaymentGateway" setup_version="1.1.2">
         <sequence>
             <module name="Magento_Sales"/>
             <module name="Magento_Payment"/>