Appraisal & Combustion; Rails 3, 6, & 7 Compat fixes

.envrc

@@ -1,9 +1,11 @@
 ### External Testing Controls
 export K_SOUP_COV_DO=true # Means you want code coverage
 export K_SOUP_COV_MIN_BRANCH=71 # Means you want to enforce X% branch coverage
-export K_SOUP_COV_MIN_LINE=90 # Means you want to enforce X% line coverage
+export K_SOUP_COV_MIN_LINE=89 # Means you want to enforce X% line coverage
 export K_SOUP_COV_MIN_HARD=true # Means you want the build to fail if the coverage thresholds are not met
 # Available formats are html, xml, rcov, lcov, json, tty
 export K_SOUP_COV_MULTI_FORMATTERS="html,tty" # What coverage output formats do you want?
 export MAX_ROWS=5 # Setting for simplecov-console gem for tty output, limits to the worst N rows of bad coverage
-export DEBUG=true # allow byebug statements
+# export DEBUG=true # allow byebug statements
+export RAILS_VERSION="~> 7.1"
+export RAILS_MAJOR_MINOR=7.1

.github/workflows/ancient.yml

@@ -0,0 +1,82 @@
+name: Rails 3 - 4.1 on EOL Ruby 2.3
+
+on:
+  push:
+    branches:
+      - 'main'
+      - '*-stable'
+      - '*-dev'
+    tags:
+      - '!*' # Do not execute on tags
+  pull_request:
+    branches:
+      - '*'
+  # Allow manually triggering the workflow.
+  workflow_dispatch:
+
+# Cancels all previous workflow runs for the same branch that have not yet completed.
+concurrency:
+  # The concurrency group contains the workflow name and the branch name.
+  group: "${{ github.workflow }}-${{ github.ref }}"
+  cancel-in-progress: true
+
+jobs:
+  test:
+    name: Specs - Ruby ${{ matrix.ruby }} & Rails ${{ matrix.rails }} ${{ matrix.name_extra || '' }}
+    if: "!contains(github.event.commits[0].message, '[ci skip]') && !contains(github.event.commits[0].message, '[skip ci]')"
+    env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+      # rspec-rails uses RAILS_VERSION internally
+      RAILS_VERSION: "~> ${{ matrix.rails }}"
+      # Our spec suite (not runtime code) uses RAILS_MAJOR_MINOR internally
+      RAILS_MAJOR_MINOR: ${{ matrix.rails }}
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - ruby: "2.3"
+            appraisal: "rails-4-1"
+            bundler: '1.17.3'
+            gemfile: vanilla
+            rails: "4.1"
+          - ruby: "2.3"
+            appraisal: "rails-4-0"
+            bundler: '1.17.3'
+            gemfile: vanilla
+            rails: "4.0"
+          - ruby: "2.3"
+            appraisal: "rails-3-2"
+            bundler: '1.17.3'
+            gemfile: vanilla
+            rails: "3.2"
+          - ruby: "2.3"
+            appraisal: "rails-3-1"
+            bundler: '1.17.3'
+            gemfile: vanilla
+            rails: "3.1"
+          - ruby: "2.3"
+            appraisal: "rails-3-0"
+            bundler: '1.17.3'
+            gemfile: vanilla
+            rails: "3.0"
+    runs-on: ubuntu-20.04
+    continue-on-error: ${{ matrix.experimental || endsWith(matrix.ruby, 'head') }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Setup Ruby & RubyGems
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          rubygems: ${{ matrix.rubygems }}
+          bundler: ${{ matrix.bundler }}
+          bundler-cache: false
+      # This will use the BUNDLE_GEMFILE set to matrix.gemfile (i.e. vanilla)
+      # We need to do this first to get appraisal installed.
+      # NOTE: This does not use the root Gemfile at all.
+      - name: Bundle for Appraisal ${{ matrix.appraisal }} (Rails v${{ matrix.rails}})
+        run: bundle _1.17.3_ install
+      - name: Install Appraisal ${{ matrix.appraisal }} (Rails v${{ matrix.rails}}) dependencies
+        run: bundle _1.17.3_ exec appraisal ${{ matrix.appraisal }} bundle _1.17.3_ install
+      - name: Run tests ${{ matrix.appraisal }} (Rails v${{ matrix.rails}})
+        run: bundle _1.17.3_ exec appraisal ${{ matrix.appraisal }} bundle _1.17.3_ exec rake test

.github/workflows/coverage.yml

@@ -1,8 +1,8 @@
 name: Ruby - Coverage
 
 env:
-  K_SOUP_COV_MIN_BRANCH: 73
-  K_SOUP_COV_MIN_LINE: 90
+  K_SOUP_COV_MIN_BRANCH: 71
+  K_SOUP_COV_MIN_LINE: 89
   K_SOUP_COV_MIN_HARD: true
 
 on:
@@ -56,7 +56,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Setup Ruby & Bundle
+      - name: Setup Ruby & RubyGems
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: "${{ matrix.ruby }}"

.github/workflows/heads.yml

@@ -51,7 +51,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Setup Ruby & Bundle
+      - name: Setup Ruby & RubyGems
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: "${{ matrix.ruby }}"

.github/workflows/legacy.yml

@@ -1,4 +1,4 @@
-name: Legacy Ruby Support
+name: Rails 4.2, 5, 6, 7 on EOL Ruby 2.5 - 3.0
 
 on:
   push:
@@ -17,43 +17,137 @@ on:
 # Cancels all previous workflow runs for the same branch that have not yet completed.
 concurrency:
   # The concurrency group contains the workflow name and the branch name.
-  group: ${{ github.workflow }}-${{ github.ref }}
+  group: "${{ github.workflow }}-${{ github.ref }}"
   cancel-in-progress: true
 
 jobs:
   test:
-    name: Ruby ${{ matrix.ruby }} ${{ matrix.name_extra || '' }}
+    name: Specs - Ruby ${{ matrix.ruby }} & Rails ${{ matrix.rails }} ${{ matrix.name_extra || '' }}
     if: "!contains(github.event.commits[0].message, '[ci skip]') && !contains(github.event.commits[0].message, '[skip ci]')"
     env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
+      # rspec-rails uses RAILS_VERSION internally
+      RAILS_VERSION: "~> ${{ matrix.rails }}"
+      # Our spec suite (not runtime code) uses RAILS_MAJOR_MINOR internally
+      RAILS_MAJOR_MINOR: ${{ matrix.rails }}
     strategy:
       fail-fast: false
       matrix:
-        experimental: [false]
-        rubygems:
-          - "2.7.11"
-        bundler:
-          - none
-        gemfile:
-          - vanilla
-        ruby:
-          - "3.0"
-          - "2.7"
-          - "2.6"
-          - "2.5"
-          - "2.4"
-          - "2.3"
+        include:
+          - ruby: "3.0"
+            appraisal: "rails-7-1"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "7.1"
+          - ruby: "3.0"
+            appraisal: "rails-7-0"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "7.0"
+          - ruby: "3.0"
+            appraisal: "rails-6-1"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "6.1"
+          - ruby: "2.7"
+            appraisal: "rails-7-1"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "7.1"
+          - ruby: "2.7"
+            appraisal: "rails-7-0"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "7.0"
+          - ruby: "2.7"
+            appraisal: "rails-6-1"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "6.1"
+          - ruby: "2.7"
+            appraisal: "rails-6-0"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "6.0"
+          - ruby: "2.7"
+            appraisal: "rails-5-2"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "5.2"
+          - ruby: "2.6"
+            appraisal: "rails-6-1"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "6.1"
+          - ruby: "2.6"
+            appraisal: "rails-6-0"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "6.0"
+          - ruby: "2.6"
+            appraisal: "rails-5-2"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "5.2"
+          - ruby: "2.5"
+            appraisal: "rails-6-1"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "6.1"
+          - ruby: "2.5"
+            appraisal: "rails-6-0"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "6.0"
+          - ruby: "2.5"
+            appraisal: "rails-5-2"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "5.2"
+          - ruby: "2.5"
+            appraisal: "rails-5-1"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "5.1"
+          - ruby: "2.5"
+            appraisal: "rails-4-2"
+            rubygems:  "3.3.27"
+            bundler: none
+            gemfile: vanilla
+            rails: "4.2"
     runs-on: ubuntu-20.04
     continue-on-error: ${{ matrix.experimental || endsWith(matrix.ruby, 'head') }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Setup Ruby & Bundle
+      - name: Setup Ruby & RubyGems
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
           rubygems: ${{ matrix.rubygems }}
           bundler: ${{ matrix.bundler }}
-          bundler-cache: true
-      - name: Run tests
-        run: bundle exec rake test
+          bundler-cache: false
+      # This will use the BUNDLE_GEMFILE set to matrix.gemfile (i.e. vanilla)
+      # We need to do this first to get appraisal installed.
+      # NOTE: This does not use the root Gemfile at all.
+      - name: Bundle for Appraisal ${{ matrix.appraisal }} (Rails v${{ matrix.rails}})
+        run: bundle
+      - name: Install Appraisal ${{ matrix.appraisal }} (Rails v${{ matrix.rails}}) dependencies
+        run: bundle exec appraisal ${{ matrix.appraisal }} bundle
+      - name: Run tests ${{ matrix.appraisal }} (Rails v${{ matrix.rails}})
+        run: bundle exec appraisal ${{ matrix.appraisal }} bundle exec rake test

.github/workflows/style.yml

@@ -22,7 +22,6 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        experimental: [true]
         rubygems:
           - latest
         bundler:
@@ -38,7 +37,7 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Setup Ruby & Bundle
+      - name: Setup Ruby & RubyGems
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}