Replace native execution. #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
approved these changes
Mar 3, 2025
| @@ -188,16 +151,14 @@ where | |||
| .default_heap_pages | |||
| .map_or(DEFAULT_HEAP_ALLOC_STRATEGY, |h| HeapAllocStrategy::Static { extra_pages: h as _ }); | |||
|
|
|||
| let wasm = WasmExecutor::builder() | |||
| let executor = ParachainExecutor::builder() | |||
| .with_execution_method(config.wasm_method) | |||
There was a problem hiding this comment.
Isn't the execution_method field deprecated anyway? Or is it just the CLI field? I remember seeing warnings when starting the node.
There was a problem hiding this comment.
Ah, good call. We can remove this and get rid of the warning.
There was a problem hiding this comment.
I checked this method and it seems that it is not for selecting Native/wasm, but rather how to instantiate the wasm. I think we should keep it.
But you're right that there is a warning for the --execution flag, which now makes even less sense to have. I'll try to find a way to remove it.
ebma
approved these changes
Mar 4, 2025
| @@ -188,16 +151,14 @@ where | |||
| .default_heap_pages | |||
| .map_or(DEFAULT_HEAP_ALLOC_STRATEGY, |h| HeapAllocStrategy::Static { extra_pages: h as _ }); | |||
|
|
|||
| let wasm = WasmExecutor::builder() | |||
| let executor = ParachainExecutor::builder() | |||
| .with_execution_method(config.wasm_method) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 518.
Context
Since the metadata-hash chain extension cannot be used with the native runtime execution, and it's use seems to be deprecated as well, we replace the use of
NativeElseWasmExecutorand useWasmExecutordirectly.