-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ebay): Starting work on eBay OAuth Provider #3483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing. I added a few comments -- can you look into these?
Hello, EBay uses a two part authentication system. First, we need to get the user's consent (and specify scopes of the application), then we place the authorization code grant request to get a User access token and a refresh token. (I am following the docs here: https://developer.ebay.com/api-docs/static/oauth-consent-request.html, https://developer.ebay.com/api-docs/static/oauth-auth-code-grant-request.html. Is it possible to support this? We would need to have a way to pass scopes. Would that be part of settings aswell? Sorry for the questions! Thanks! |
What you describe is regular OAuth2 functionality -- the other providers do similar things. I suggest you have a look at the |
I implemented some of the changes discussed. I wrote some tests (probably more than necessary), but I am not too sure how to test it |
Abandoned, closing. |
Submitting Pull Requests
General
Examples:
"fix(google): Fixed foobar bug"
,"feat(accounts): Added foobar feature"
.ChangeLog.rst
.AUTHORS
.Provider Specifics
In case you add a new provider:
test_settings.py::INSTALLED_APPS
anddocs/installation.rst::INSTALLED_APPS
.docs/providers/<provider name>.rst
anddocs/providers/index.rst
Provider Specifics toctree.docs/overview.rst
.