-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-1234 Ability to use non default port 27017 for Mongo components #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad8bc5e
to
294d2ba
Compare
298a02c
to
3c94173
Compare
egegunes
previously approved these changes
Feb 20, 2025
hors
approved these changes
Feb 20, 2025
egegunes
approved these changes
Feb 20, 2025
nmarukovich
approved these changes
Feb 20, 2025
commit: a1c1e84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Until now all the major mongo components i.e. mongos, mongod and cfg were using the default mongodb port 27017. With this PR we introduce a new configuration option for setting the port for the aforementioned components.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Parse from the mongo config the port for mongos, mongod and cfg and use it throughout the service, We also change some of our e2e tests to verify the changes and ensure no breaking changes.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability