K8SPSMDB-1256 refactor backup agent (pbm) mongo uri construction

[gkech]

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

tested image: export IMAGE=perconalab/percona-server-mongodb-operator:K8SPSMDB-1256-9911

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?
• Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are all needed new/changed options added to the Helm Chart?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported MongoDB version?
• Does the change support oldest and newest supported Kubernetes version?

[hors]

@gkech, we need to use the new value only in case of
if cr.CompareVersion("1.20.0") >= 0 {

please check the code how we use it

[gkech]

I'll do, thanks Slava

[gkech]

1a907df

[nmarukovich]

it's ok for me and we merge like this, but I prefer to use inverted logic:

mongoDBURI = buildMongoDBURI(ctx, tlsEnabled, sslSecret)
if cr.CompareVersion("1.20.0") < 0 {
			mongoDBURI := "mongodb://$(PBM_AGENT_MONGODB_USERNAME):$(PBM_AGENT_MONGODB_PASSWORD)@$(POD_NAME)"
		}

It's easier delete unnecessary code when we don't need it.

[gkech]

When it is time to delete code from this implementation, we will have to touch either way the whole block since this part is nested in the if cr.CompareVersion("1.14.0") >= 0 clause. And since we already have this kind of nesting, inverting the logic makes it harder to read because the logical operations are on different direction 😅

I recommend to keep it as is for now and revisit this when it is time to handle old versions.

[JNKPercona]

Test name	Status
arbiter	passed
balancer	passed
custom-replset-name	passed
custom-tls	passed
custom-users-roles	passed
custom-users-roles-sharded	passed
cross-site-sharded	passed
data-at-rest-encryption	passed
data-sharded	passed
demand-backup	passed
demand-backup-fs	passed
demand-backup-eks-credentials-irsa	passed
demand-backup-physical	passed
demand-backup-physical-sharded	passed
demand-backup-sharded	passed
expose-sharded	passed
ignore-labels-annotations	passed
init-deploy	passed
finalizer	passed
ldap	passed
ldap-tls	passed
limits	passed
liveness	passed
mongod-major-upgrade	passed
mongod-major-upgrade-sharded	passed
monitoring-2-0	passed
multi-cluster-service	failure
non-voting	passed
one-pod	passed
operator-self-healing-chaos	passed
pitr	passed
pitr-sharded	passed
pitr-physical	passed
preinit-updates	passed
pvc-resize	passed
recover-no-primary	passed
replset-overrides	passed
rs-shard-migration	passed
scaling	passed
scheduled-backup	passed
security-context	passed
self-healing-chaos	passed
service-per-pod	passed
serviceless-external-nodes	passed
smart-update	passed
split-horizon	passed
stable-resource-version	passed
storage	passed
tls-issue-cert-manager	passed
upgrade	passed
upgrade-consistency	passed
upgrade-consistency-sharded-tls	passed
upgrade-sharded	passed
users	passed
version-service	passed
We run 55 out of 55

commit: 1a907df
image: perconalab/percona-server-mongodb-operator:PR-1835-1a907dfc