K8SPSMDB-1263: retry on error during running backup #1838
+47
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
hors,
egegunes,
nmarukovich and
gkech
as code owners
gkech
reviewed
Feb 24, 2025
| } | ||
|
|
||
| time.Sleep(5 * time.Second) | ||
| return bcp.Status(ctx, cr) | ||
|
|
||
| err := retry.OnError(defaultBackoff, func(err error) bool { return err != nil }, func() error { |
There was a problem hiding this comment.
Since the 1st retry will be executed after 5 seconds due to the time.Sleep(5 * time.Second) we have already, maybe we can adjust the default backoff config to start after 10 seconds. With the current config we will start 1 retry after 5 seconds, then again after 5 seconds and then after 10. WDYT?
gkech
reviewed
Feb 24, 2025
Comment on lines
243
to
245
| var err error | ||
| status, err = bcp.Status(ctx, cr) | ||
| return err |
There was a problem hiding this comment.
Maybe writing this like this
updatedStatus, err := bcp.Status(ctx, cr)
if err == nil {
status = updatedStatus
}
return err
will make it more clear what status we are setting and what error we return
gkech
approved these changes
Feb 24, 2025
nmarukovich
approved these changes
Feb 25, 2025
commit: ea18c4a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPSMDB-1263
DESCRIPTION
Problem:
During a long backup,
psmdb-backupmay enter anerrorstate with the error:check for concurrent jobs: getting pbm object: create PBM connection to...Cause:
The operator attempts to connect to the mongod pods but may fail due to some connection problem. However, it does not retry to connect and instead sets an
errorstate for the backup. However, PBM continues and successfully completes the backup.Solution:
The operator should retry connecting to the database during a backup if an error occurs.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability