Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished the application #1

Merged
merged 39 commits into from
Jun 26, 2020
Merged

Finished the application #1

merged 39 commits into from
Jun 26, 2020

Conversation

peterrobert
Copy link
Owner

On this milestone I worked on the following:

1.Created the models
2.Created the controllers
3.Created the views
4.Performed testing
5.Fixed rubocop errors

@peterrobert
Copy link
Owner Author

Thank you for the last review.

  1. I have fixed all linter issues and enabled linting to my repo.

However, there are a few issues on the review

  1. kindly I have solved the n+1 issue. I have also explained it in the video. Kindly just double check on that.
  2. I have also done the group transaction as per the requirement. Kindly also double check on that.
  3. I have also done the unit testing as per requirement. Kindly double check on that.

@peterrobert peterrobert merged commit 98375a6 into development Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant